Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: add vbe modesetting command #352

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

adamgreloch
Copy link
Member

@adamgreloch adamgreloch commented Sep 24, 2024

Adds command vbe for setting up graphics mode using VESA VBE 2.0 real mode interface. The command checks whether a specified mode (preferred/fallback) is supported by the VGA controller, fetches its details, sets it and stores necessary info (width, height, bpp, framebuffer address, etc.) in the syspage. The info can be then queried using platformctl by userspace apps

JIRA: RTOS-906

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: ia32

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
@adamgreloch adamgreloch force-pushed the adamgreloch/RTOS-906 branch 2 times, most recently from 3fcfa51 to 9d1bffe Compare October 4, 2024 09:45
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
cmds/vbe.c Outdated Show resolved Hide resolved
Adds command `vbe` for setting up graphics mode using VESA VBE 2.0 real
mode interface. The command checks whether a specified mode
(preferred/fallback) is supported by the VGA controller, fetches its
details, sets it and stores necessary info (width, height, bpp,
framebuffer address, etc.) in the syspage. The info can be then queried
using platformctl by userspace apps

JIRA: RTOS-906
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Oct 4, 2024

Unit Test Results

7 725 tests  ±0   7 010 ✅ ±0   37m 28s ⏱️ -1s
  445 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 550404f. ± Comparison against base commit 420eca3.

@adamgreloch adamgreloch merged commit 32fcc3b into master Oct 4, 2024
36 checks passed
@adamgreloch adamgreloch deleted the adamgreloch/RTOS-906 branch October 4, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants